Димитър качи първо решение на 26.11.2018 13:38 (преди над 4 години)
Добра работа, разумно решение.
Към профила на Димитър Иринков
Compiling solution v0.1.0 (/tmp/d20190123-22631-pk53tu/solution) Finished dev [unoptimized + debuginfo] target(s) in 5.12s Running target/debug/deps/solution-2e785d603b538f71 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out Running target/debug/deps/solution_test-29808948fb50ed3a running 15 tests test solution_test::test_equailty_symmetry ... ok test solution_test::test_equality_basic ... ok test solution_test::test_equality_floating ... ok test solution_test::test_line_constructors ... ok test solution_test::test_line_equality_by_points ... ok test solution_test::test_line_equality_by_points_and_vectors ... ok test solution_test::test_line_equality_by_vectors ... ok test solution_test::test_line_validity ... ok test solution_test::test_number_by_vector ... ok test solution_test::test_number_vector_multiplication_with_precision ... ok test solution_test::test_point_distance ... ok test solution_test::test_points_minus_points ... ok test solution_test::test_points_plus_vectors ... ok test solution_test::test_vector_by_vector ... ok test solution_test::test_vector_by_vector_cross ... ok test result: ok. 15 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out Doc-tests solution running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Добра работа, разумно решение.
Малко неконсистентен naming. Ако
p
ти беше точката, можешеv
да ти е вектора. Аз лично съм ги кръстилorigin
иdirection
, но при всички положения,norm
е малко странно име, предвид, че вектора не е нормиран (т.е. не е scale-нат, така че дължината му да е 1).Може и без тази if-клауза. На последния ред може просто да има
dis1 < std::f64::EPSILON && dis2 < std::f64::EPSILON
.